Skip to content

BUG Fix for Issue #12565 - font size on secondary_y #16952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2017
Merged

BUG Fix for Issue #12565 - font size on secondary_y #16952

merged 4 commits into from
Jul 15, 2017

Conversation

Morgan243
Copy link
Contributor

@Morgan243 Morgan243 commented Jul 15, 2017 •
edited
Loading

There may be other plotting methods that need testing.

@Morgan243
Fix for Issue pandas-dev#12565 - font size on secondary_y
531b9e5 
There may be other plotting methods that need testing.
@pep8speaks
Copy link

pep8speaks commented Jul 15, 2017 •
edited
Loading

Hello @Morgan243! Thanks for updating the PR.

Line 294:9: E741 ambiguous variable name 'l'
Line 302:9: E741 ambiguous variable name 'l'

Comment last updated on July 15, 2017 at 20:25 Hours UTC

TomAugspurger
TomAugspurger reviewed Jul 15, 2017
View reviewed changes
pandas/tests/plotting/test_frame.py Outdated
@@ -2733,6 +2733,22 @@ def test_rcParams_bar_colors(self):
barplot = pd.DataFrame([[1, 2, 3]]).plot(kind="bar")
assert color_tuples == [c.get_facecolor() for c in barplot.patches]

@pytest.mark.parametrize('method', ['line', 'barh', 'bar'])
def test_secondary_axis_font_size(self, method):
df = (pd.DataFrame(np.random.randn(15, 2),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add comment with the github issue number here like # GH: 12565

@codecov
Copy link

codecov bot commented Jul 15, 2017

Codecov Report

Merging #16952 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16952      +/-   ##
==========================================
- Coverage   90.98%   90.97%   -0.02%     
==========================================
  Files         161      161              
  Lines       49288    49292       +4     
==========================================
- Hits        44846    44844       -2     
- Misses       4442     4448       +6
Flag Coverage Δ
#multiple 88.74% <100%> (ø) ⬆️
#single 40.19% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/plotting/_core.py 82.72% <100%> (+0.2%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.76% <0%> (-0.1%) ⬇️
pandas/plotting/_timeseries.py 60.73% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7500218...9e06e9b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 15, 2017 •
edited
Loading

Codecov Report

Merging #16952 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16952      +/-   ##
==========================================
- Coverage   90.98%   90.97%   -0.02%     
==========================================
  Files         161      161              
  Lines       49288    49292       +4     
==========================================
- Hits        44846    44844       -2     
- Misses       4442     4448       +6
Flag Coverage Δ
#multiple 88.74% <100%> (ø) ⬆️
#single 40.19% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/plotting/_core.py 82.72% <100%> (+0.2%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.76% <0%> (-0.1%) ⬇️
pandas/core/series.py 94.89% <0%> (-0.01%) ⬇️
pandas/core/dtypes/missing.py 87.03% <0%> (+0.16%) ⬆️
pandas/plotting/_timeseries.py 60.73% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7500218...4642a2d. Read the comment docs.

gfyoung
gfyoung reviewed Jul 15, 2017
View reviewed changes
doc/source/whatsnew/v0.21.0.txt Outdated
@@ -166,7 +166,7 @@ I/O

Plotting
^^^^^^^^

- Bug in plotting methods using ``secondary_y`` and ``fontsize`` not setting secondary axes font size (:issue:`12565`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"axis" not "axes" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I think 'axis' is right

@gfyoung
Copy link
Member

gfyoung commented Jul 15, 2017

@Morgan243 : Ping when tests pass, and we will merge this!

@Morgan243
Copy link
Contributor Author

@gfyoung tests passed!

@gfyoung gfyoung merged commit 8e3d831 into pandas-dev:master Jul 15, 2017
@gfyoung
Copy link
Member

gfyoung commented Jul 15, 2017

Thanks @Morgan243 !

@gfyoung gfyoung added this to the 0.21.0 milestone Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Bug Visualization plotting
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

BUG?: secondary_y is unaltered by fontsize parameter
5 participants
@Morgan243 @pep8speaks @gfyoung @TomAugspurger @jreback